Picture of Brian Gray
FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Brian Gray - Tuesday, 3 September 2013, 08:05 AM
 

The Marking Manager block reports that all of my students have not submitted any activities for 7 days, although they have been and I've been grading the submissions.

I use the standard assignment module with file upload and online text enabled.  I require students to click the submit button.

What is the logic used to determine if a student has submitted any activities or not?
Picture of Fernando Oliveira
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Fernando Oliveira - Tuesday, 3 September 2013, 10:15 AM
 
Brian,

Please let me know if you are experiencing this problem with the latest Marking Manager version. If so, would you be able to send me login details to your site (or at least to a demo course) so that I can take a look?

Thanks,
Fernando
Picture of Brian Gray
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Brian Gray - Tuesday, 3 September 2013, 12:33 PM
 
The new version does not correct the erroneous inactivity reports.  

I'll re-create the situation in a demo course with my test student accounts, and provide you with account info.  Do you prefer to get that info through Moodle Message or email?

bkg
Picture of Fernando Oliveira
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Fernando Oliveira - Tuesday, 3 September 2013, 01:06 PM
 
Email would be best.
Picture of Fernando Oliveira
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Fernando Oliveira - Sunday, 8 September 2013, 11:07 AM
 
Hi Brian,

The Marking Manager block was updated. Would you mind installing the latest code from GitHub and testing it out? Here's a link to the code:

https://github.com/fernandooliveira/moodle-block_marking_manager


Thanks,
Fernando
Picture of Brian Gray
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Brian Gray - Sunday, 8 September 2013, 01:05 PM
 
My server is now running Moodle 2.5.1+ (Build: 20130905) - minor updates released this week.  That update removed the patch to themes/base/config.php.

I updated FN Marking Manager to version 2013083102 from the link you provided.  I left the Hide all blocks options set to No.
 
The good news is that with "Hide all blocks" set at No and with the server debug level to NORMAL, I do NOT see the stack trace error messages I reported a few days ago.  

The bad news is that I am still seeing all students reported as submitting no activity in the past 7 days.  In the Test-17 class you looked at on my Moodle server, I submitted an assignment for one of the students today, just to be sure.

One thing that you should know (even though I think it doesn't matter)...the course I imported the assignments in Test-17 from uses Activity Completion Tracking.  Each assignment has settings to mark it as complete when the student submits the assignment.  When I copied the assignments to Test-17, that setting was copied along with everything else, but I did not turn on completion tracking in the course settings page. If you looked at the settings for any of the individual assignments, you would not have seen the Activity Completion section on the settings page.  Completion tracking is now active in Test-17, so you will see those settings.

I don't think it matters because I turned the tracking off on the assignment that I submitted for a student, and nothing changed.

I looked at the section of your code that does the calculation of how many students have not submitted recently.  I see generally what you're doing but couldn't follow the details because I didn't have time to go diving into the Moodle library calls to find the actual database queries.

In addition to my live system, I maintain a test server that we can use to do more extensive debugging if that will be useful to you.  I often put a copy of the live system onto the test environment to play around with something.  If you want to add some logging statements to your code to see what my system is actually finding, I'll be glad to try it on my test system.

bkg

Picture of Brian Gray
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Brian Gray - Sunday, 8 September 2013, 01:32 PM
 
Update: I do get the stack trace errors when displaying the gradebook page.  Adding the code patch and setting Hide all blocks to Yes prevents these errors.


Picture of Fernando Oliveira
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Fernando Oliveira - Monday, 9 September 2013, 09:42 AM
 
Thanks for testing, Brian. Looking into this.
Picture of Fernando Oliveira
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Fernando Oliveira - Friday, 13 September 2013, 12:14 PM
 
Brian, please try the latest release and report back with any issues: https://moodle.org/plugins/pluginversion.php?id=4079

-Fernando
Picture of Brian Gray
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Brian Gray - Friday, 13 September 2013, 02:13 PM
 

It looks like you've fixed the problem with the "students have not submitted any activities for 7 days" report.  I'll do a little more testing to verify, but everything I've seen so far looks good.  Well done!

The gradebook link is broken. 

Warning: require_once(xxxx\moodle/blocks/fn_myprogress/lib.php) [function.require-once]: failed to open stream: No such file or directory in xxxx\moodle\blocks\fn_marking\simple_gradebook.php on line 8

Previously, the gradebook link was:

http://xxx.xxx.org/blocks/fn_marking/simple_gradebook.php?id=282

and now it's pointing to the fn_myprogress block.



bkg
Picture of Brian Gray
Re: FN Marking on Moodle 2.5: how is "not submitted any activities" determined?
by Brian Gray - Saturday, 14 September 2013, 01:38 PM
 
I neglected to say that the block is reporting version 2013083103 after the installation of the Release Candidate you linked to.
Moodle Theme by NewSchool Learning